[Asterisk-code-review] app_queue: Add music on hold option to Queue. (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17940 )

Change subject: app_queue: Add music on hold option to Queue.
......................................................................


Patch Set 5:

(2 comments)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/17940/comment/3e7144b6_a5b17062 
PS4, Line 205: 						<para>Custom music on hold class to use, which will override the
             : 						music on hold class configured in <filename>queues.conf</filename>,
             : 						if specified.</para>
> If there is an order precedence between the channel variable and "m" option that should be documente […]
Good point. I actually never use CHANNEL(musicclass) and this showed me why - CHANNEL(musicclass) takes precedence over the m option, which is very non-intuitive. I don't think most users would realize that.
If nothing else, this would let them know NOT to use CHANNEL (or at least clear it first)


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/17940/comment/a0ee825b_09f273f8 
PS4, Line 67: ; using the m option when calling the Queue application or if set
> Is there a precedence here between channel and "m" option? Like "m" overrides channel variable, whic […]
Yup, same as before, I've made that clearer here.
I think the way it actually works currently is a bit silly, but that's an issue for another day...



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17940
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie25a48569cf8755c305c9438b1ed292c3adcf8d7
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 21:33:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220329/e4d3c3b1/attachment.html>