[Asterisk-code-review] app_queue: Add music on hold option to Queue. (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17940 )

Change subject: app_queue: Add music on hold option to Queue.
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/17940/comment/1280df15_aad8924b 
PS4, Line 205: 						<para>Custom music on hold class to use, which will override the
             : 						music on hold class configured in <filename>queues.conf</filename>,
             : 						if specified.</para>
If there is an order precedence between the channel variable and "m" option that should be documented too just in case both get specified.


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/17940/comment/6bcbd143_33623835 
PS4, Line 67: ; using the m option when calling the Queue application or if set
Is there a precedence here between channel and "m" option? Like "m" overrides channel variable, which in turns overrides config? If so it'd be good to state that just in case someone sets both or all three.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17940
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie25a48569cf8755c305c9438b1ed292c3adcf8d7
Gerrit-Change-Number: 17940
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 29 Mar 2022 20:24:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220329/26b36a12/attachment.html>