[Asterisk-code-review] make_xml_documentation: Remove usage of get_sourceable_makeopts (asterisk[19])

George Joseph asteriskteam at digium.com
Mon Mar 28 08:14:07 CDT 2022


Hello Joshua Colp, Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/18267

to look at the new patch set (#2).

Change subject: make_xml_documentation: Remove usage of get_sourceable_makeopts
......................................................................

make_xml_documentation: Remove usage of get_sourceable_makeopts

get_sourceable_makeopts wasn't handling variables with embedded
double quotes in them very well.  One example was the DOWNLOAD
variable when curl was being used instead of wget.  Rather than
trying to fix get_sourceable_makeopts, it's just been removed.

ASTERISK-29986
Reported by: Stefan Ruijsenaars

Change-Id: Idf2a90902228c2558daa5be7a4f8327556099cd2
---
M Makefile
D build_tools/get_sourceable_makeopts
M build_tools/make_xml_documentation
3 files changed, 19 insertions(+), 82 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/67/18267/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18267
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19
Gerrit-Change-Id: Idf2a90902228c2558daa5be7a4f8327556099cd2
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220328/f7a77d5e/attachment.html>


More information about the asterisk-code-review mailing list