[Asterisk-code-review] download_externals: Use HTTPS for downloads (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Wed Mar 23 18:05:51 CDT 2022


Kevin Harwell has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/18249 )

Change subject: download_externals: Use HTTPS for downloads
......................................................................

download_externals: Use HTTPS for downloads

ASTERISK-29980 #close

Change-Id: I7b347665822ea2774dd322276c09be67914d2065
---
M build_tools/download_externals
M codecs/codecs.xml
M res/res.xml
3 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, approved
  Michael Bradeen: Looks good to me, but someone else must approve
  Kevin Harwell: Approved for Submit



diff --git a/build_tools/download_externals b/build_tools/download_externals
index 0f82eff..cb2cd03 100755
--- a/build_tools/download_externals
+++ b/build_tools/download_externals
@@ -109,7 +109,7 @@
 		remote_url="${remote_url}/asterisk-${major_version}/x86-${host_bits}"
 	else
 		directory_name=$(${XMLSTARLET} sel -t -v "/menu/category/member[@name = '${member_name}']/member_data/downloader/@directory_name" ${ASTTOPDIR}/menuselect-tree || :)
-		remote_url="http://downloads.digium.com/pub/telephony/${directory_name:-${module_name}}/asterisk-${major_version}/x86-${host_bits}"
+		remote_url="https://downloads.digium.com/pub/telephony/${directory_name:-${module_name}}/asterisk-${major_version}/x86-${host_bits}"
 	fi
 fi
 
diff --git a/codecs/codecs.xml b/codecs/codecs.xml
index 996a355..c7833e6 100644
--- a/codecs/codecs.xml
+++ b/codecs/codecs.xml
@@ -1,4 +1,4 @@
-<member name="codec_opus" displayname="Download the Opus codec from Digium.  See http://downloads.digium.com/pub/telephony/codec_opus/README.">
+<member name="codec_opus" displayname="Download the Opus codec from Digium.  See https://downloads.digium.com/pub/telephony/codec_opus/README.">
 	<support_level>external</support_level>
 	<conflict>no_binary_modules</conflict>
 	<depend>xmlstarlet</depend>
@@ -6,28 +6,28 @@
 	<depend>res_format_attr_opus</depend>
 	<defaultenabled>no</defaultenabled>
 </member>
-<member name="codec_silk" displayname="Download the SILK codec from Digium.  See http://downloads.digium.com/pub/telephony/codec_silk/README.">
+<member name="codec_silk" displayname="Download the SILK codec from Digium.  See https://downloads.digium.com/pub/telephony/codec_silk/README.">
 	<support_level>external</support_level>
 	<conflict>no_binary_modules</conflict>
 	<depend>xmlstarlet</depend>
 	<depend>bash</depend>
 	<defaultenabled>no</defaultenabled>
 </member>
-<member name="codec_siren7" displayname="Download the Siren7 codec from Digium.  See http://downloads.digium.com/pub/telephony/codec_siren7/README.">
+<member name="codec_siren7" displayname="Download the Siren7 codec from Digium.  See https://downloads.digium.com/pub/telephony/codec_siren7/README.">
 	<support_level>external</support_level>
 	<conflict>no_binary_modules</conflict>
 	<depend>xmlstarlet</depend>
 	<depend>bash</depend>
 	<defaultenabled>no</defaultenabled>
 </member>
-<member name="codec_siren14" displayname="Download the Siren14 codec from Digium.  See http://downloads.digium.com/pub/telephony/codec_siren14/README.">
+<member name="codec_siren14" displayname="Download the Siren14 codec from Digium.  See https://downloads.digium.com/pub/telephony/codec_siren14/README.">
 	<support_level>external</support_level>
 	<conflict>no_binary_modules</conflict>
 	<depend>xmlstarlet</depend>
 	<depend>bash</depend>
 	<defaultenabled>no</defaultenabled>
 </member>
-<member name="codec_g729a" displayname="Download the g729a codec from Digium.  A license must be purchased for this codec.  See http://downloads.digium.com/pub/telephony/codec_g729/README.">
+<member name="codec_g729a" displayname="Download the g729a codec from Digium.  A license must be purchased for this codec.  See https://downloads.digium.com/pub/telephony/codec_g729/README.">
 	<support_level>external</support_level>
 	<conflict>no_binary_modules</conflict>
 	<depend>xmlstarlet</depend>
diff --git a/res/res.xml b/res/res.xml
index ace1792..0b34ec9 100644
--- a/res/res.xml
+++ b/res/res.xml
@@ -1,4 +1,4 @@
-<member name="res_digium_phone" displayname="Download the Digium Phone Module for Asterisk.  See http://downloads.digium.com/pub/telephony/res_digium_phone/README.">
+<member name="res_digium_phone" displayname="Download the Digium Phone Module for Asterisk.  See https://downloads.digium.com/pub/telephony/res_digium_phone/README.">
 	<support_level>external</support_level>
 	<conflict>no_binary_modules</conflict>
 	<depend>xmlstarlet</depend>

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18249
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7b347665822ea2774dd322276c09be67914d2065
Gerrit-Change-Number: 18249
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220323/58307e03/attachment.html>


More information about the asterisk-code-review mailing list