[Asterisk-code-review] res_pjsip_pubsub: RLS 'uri' list attribute mismatch with SUBSCRIBE re... (asterisk[16])
Alexei Gradinari
asteriskteam at digium.com
Mon Mar 21 09:15:38 CDT 2022
Attention is currently required from: Joshua Colp.
Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18193 )
Change subject: res_pjsip_pubsub: RLS 'uri' list attribute mismatch with SUBSCRIBE request
......................................................................
Patch Set 5:
(2 comments)
File res/res_pjsip_pubsub.c:
https://gerrit.asterisk.org/c/asterisk/+/18193/comment/c9037e57_eb9dfbaf
PS3, Line 1541: ast_sip_mod_data_set(dlg->pool, dlg->mod_data, pubsub_module.id, MOD_DATA_MSG,
> You don't need to alter the function definition or retrieve the request URI in this function. […]
Done
https://gerrit.asterisk.org/c/asterisk/+/18193/comment/d251c133_1f30744b
PS3, Line 1282: pjsip_sip_uri_assign(tree->dlg->pool, sub->uri, resource_uri);
> You can get access to the rdata here using: […]
Done
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18193
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1fcfc08fd589677f40608c59a4e143c45ee05f6c
Gerrit-Change-Number: 18193
Gerrit-PatchSet: 5
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 21 Mar 2022 14:15:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220321/1683b091/attachment.html>
More information about the asterisk-code-review
mailing list