[Asterisk-code-review] res_pjsip_sdp_rtp: Improve detecting of lack of RTP activity (asterisk[16])

[Boris P. Korzun]

Attention is currently required from: Joshua Colp.
Boris P. Korzun has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18071 )

Change subject: res_pjsip_sdp_rtp: Improve detecting of lack of RTP activity
......................................................................


Patch Set 3:

(3 comments)

File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/18071/comment/b20caad1_0e8bd450 
PS1, Line 124: 	timeout = ast_rtp_instance_get_timeout(rtp);
> You retrieve the value of timeout, and then do this check: […]
The timeout variable is used not only in the block:
 if (ast_channel_state(chan) != AST_STATE_UP || !ast_sockaddr_isnull(&session_media->direct_media_addr)) { }

But also in a later block:

 if (elapsed < timeout) { }


https://gerrit.asterisk.org/c/asterisk/+/18071/comment/05d40612_672684ae 
PS1, Line 129: 		ast_rtp_instance_set_last_rx(rtp, now);
> The indentation of this is not correct
Fixed


https://gerrit.asterisk.org/c/asterisk/+/18071/comment/72904598_55017f9e 
PS1, Line 131: 		return timeout * 500; /* recheck after half timeout */
> Comment this with the code
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18071
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I07326d5b9c40f25db717fd6075f6f3a8d77279eb
Gerrit-Change-Number: 18071
Gerrit-PatchSet: 3
Gerrit-Owner: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 21 Mar 2022 12:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220321/be21f487/attachment.html>