[Asterisk-code-review] res_pjsip_pubsub: RLS 'uri' list attribute mismatch with SUBSCRIBE re... (asterisk[16])

[Alexei Gradinari]

Attention is currently required from: Joshua Colp.
Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18193 )

Change subject: res_pjsip_pubsub: RLS 'uri' list attribute mismatch with SUBSCRIBE request
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> Ah sorry, that's the message - not the rdata - but it should still be possible to get the request UR […]
Do you suggest to recreate the rdata by parsing the message every time when allocate_subscription?
I am against allocating extra memory and parsing the message on every resource in the list instead of simple pass the pointer to the already allocated request URI.

Even doing this we have to be sure that the saved message is the original message on creating subscription, as the re-subscription message contains different request URI.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18193
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1fcfc08fd589677f40608c59a4e143c45ee05f6c
Gerrit-Change-Number: 18193
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 16:06:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220315/8e7e0258/attachment-0001.html>