[Asterisk-code-review] chan_sip: SIP route header is missing on UPDATE (asterisk[16])

[Joshua Colp]

Attention is currently required from: Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18189 )

Change subject: chan_sip: SIP route header is missing on UPDATE
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/18189/comment/b324ee49_f2aad640 
PS2, Line 12454: 			/* set_destination on UPDATE in early dialog,
This comment could be better worded:

/* Calling set_destination for an UPDATE in early dialog
 * will result in mangling of the target for a subsequent
 * CANCEL according to ASTERISK-24628 so do not it.
 */



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18189
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id1920ecbfea7739a038b14dc94487ecfe7b57eef
Gerrit-Change-Number: 18189
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Tue, 15 Mar 2022 11:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220315/de9ff8ce/attachment.html>