[Asterisk-code-review] time: add support for time64 libcs (asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue Mar 15 05:57:29 CDT 2022


Attention is currently required from: Philip Prindeville.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18123 )

Change subject: time: add support for time64 libcs
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

File include/asterisk/time.h:

https://gerrit.asterisk.org/c/asterisk/+/18123/comment/2fc729e4_a99e442a 
PS9, Line 39:  * Formatted in base 10, UINT64_MAX is 20 digits long, plus one for NUL.
Extend the documentation to state this define should be used to size a char for usage with ast_time_t_to_string


https://gerrit.asterisk.org/c/asterisk/+/18123/comment/1c75f637_73cd29a1 
PS9, Line 41: #define TIME_T_LEN		21
We prefix things like this with AST_ to indicate it is system wide.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18123
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id7b25bdca8f92e34229f6454f6c3e500f2cd6f56
Gerrit-Change-Number: 18123
Gerrit-PatchSet: 9
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 15 Mar 2022 10:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220315/80d8bff8/attachment.html>


More information about the asterisk-code-review mailing list