[Asterisk-code-review] res_pjsip_geolocation: Initial commit (asterisk[development/16/geolocation])

[George Joseph]

Attention is currently required from: Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18191 )

Change subject: res_pjsip_geolocation:  Initial commit
......................................................................


Patch Set 3:

(1 comment)

File res/res_geolocation/geoloc_datastore.c:

https://gerrit.asterisk.org/c/asterisk/+/18191/comment/1d90b8c7_c99bd663 
PS3, Line 96: 	rc = AST_VECTOR_APPEND(&eds->eprofiles, eprofile);
            : 	if (rc != 0) {
            : 		ast_log(LOG_ERROR, "Couldn't add eprofile '%s' to geoloc datastore '%s'\n", eprofile->id, eds->id);
            : 	}
> > I'm personally not a fan of public API calls stealing refs, and unsure what our convention is if w […]
Meant to say "fixed in a later commit"



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18191
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I6ccb5108a5eec060efb8116502fbff3cc63d7554
Gerrit-Change-Number: 18191
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 13:09:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220311/42f14797/attachment.html>