[Asterisk-code-review] res_geolocation: eprofile, parsing, tests and more (asterisk[development/16/geolocation])

[George Joseph]

Attention is currently required from: Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18127 )

Change subject: res_geolocation: eprofile, parsing, tests and more
......................................................................


Patch Set 4:

(2 comments)

File main/config.c:

https://gerrit.asterisk.org/c/asterisk/+/18127/comment/f5425d73_c80a8d06 
PS4, Line 748: 		item_name = ast_strsep_strict(&item, nv_sep, quote, AST_STRSEP_ALL);
             : 
             : 		item_value = ast_strsep_strict(&item, nv_sep, quote, AST_STRSEP_ALL);
             : 
             : 		new_var = ast_variable_new(item_name, item_value, "");
> It appears ast_strsep_strict can return NULL under some circumstances, so item_name and item_value need to be checked for null before calling ast_variable_new.

Fixed in 18192.


File res/res_geolocation/geoloc_eprofile.c:

https://gerrit.asterisk.org/c/asterisk/+/18127/comment/fe4c5b72_3e921020 
PS4, Line 342: 	if (!pidf_lo_xslt) {
             : 		ast_log(LOG_ERROR, "Unable to read pidf_lo_xslt from memory\n");
             : 		return AST_MODULE_LOAD_DECLINE;
> Need to unref geoloc_sorcery here before returning.

Will be fixed in later review.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18127
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I50b66bd041b2a62ab329406f20dbaeef1fa68fc1
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 12:43:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220311/1d769884/attachment.html>