[Asterisk-code-review] time: add support for time64 libcs (asterisk[16])

[Joshua Colp]

Attention is currently required from: Philip Prindeville.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18123 )

Change subject: time: add support for time64 libcs
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

File res/res_calendar_caldav.c:

https://gerrit.asterisk.org/c/asterisk/+/18123/comment/d22e1c07_4a3d8a68 
PS2, Line 407: 			char tmp[24];
> 21 is the minimal amount of characters required to hold a UINT16_MAX plus NUL character. […]
Okay, so this should be a #define with a comment explaining why 24 was chosen instead of having it sprinkled across the tree without context.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18123
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id7b25bdca8f92e34229f6454f6c3e500f2cd6f56
Gerrit-Change-Number: 18123
Gerrit-PatchSet: 7
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 12:25:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220310/61278cd9/attachment-0001.html>