[Asterisk-code-review] chan_pjsip: Add secure bridge signaling and media. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18186 )

Change subject: chan_pjsip: Add secure bridge signaling and media.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18186/comment/7e8eb7d4_5deab2e9 
PS1, Line 1257: 		dlg = channel->session->inv_session->dlg;
This violates the PJSIP threading model. You must queue a task on a SIP thread in order to access/use PJSIP things, such as the dlg or creating a memory pool.

This also applies to query option.


https://gerrit.asterisk.org/c/asterisk/+/18186/comment/9d89d4f9_37ee0792 
PS1, Line 1261: 			dest.flag &= ~PJSIP_TRANSPORT_SECURE;
This doesn't enforce any kind of secure transport requirement. Dest is populated with the destination information, changing it doesn't change the dialog.


https://gerrit.asterisk.org/c/asterisk/+/18186/comment/757b9aaa_175b6ec1 
PS1, Line 1273: 			channel->session->endpoint->media.rtp.encryption = AST_SIP_MEDIA_ENCRYPT_NONE;
This violates a fundamental principal of sorcery - sorcery objects are immutable. Read only. You can not touch them. You may not alter media.rtp.encryption here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18186
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I089ec68601c80daf293193c8f4933fd87d7b2a17
Gerrit-Change-Number: 18186
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 12:19:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220310/4a2ba244/attachment.html>