[Asterisk-code-review] apps/confbridge: Added hearjoin option to control who hears sound_join (asterisk[16])

[Michael Cargile]

Attention is currently required from: N A, Joshua Colp, Kevin Harwell.
Michael Cargile has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18072 )

Change subject: apps/confbridge: Added hearjoin option to control who hears sound_join
......................................................................


Patch Set 4:

(4 comments)

Patchset:

PS2: 
> This will need an entry in CHANGES.txt as well: […]
Done.


File apps/app_confbridge.c:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/55059910_8967d820 
PS3, Line 2723: 	/* Play the Join sound to both the conference and the user entering. */
> This comment is no longer accurate
Changed


File apps/confbridge/conf_config_parser.c:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/c456a270_1ea55d90 
PS3, Line 100: 				<configOption name="hearjoin">
> The standard for ConfBridge is to separate things using _. […]
Changed


File configs/samples/confbridge.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/697a85ef_61e78ee8 
PS1, Line 44: ;hearjoin=yes     ; Sets if a user joining the conference should hear the sound_join 
> Trailing whitespace here (redness)
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18072
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I856bd66dc0dfa057323860a6418c1371d249abd2
Gerrit-Change-Number: 18072
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Cargile <mikec at vicidial.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 08 Mar 2022 18:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220308/f15cde15/attachment.html>