[Asterisk-code-review] time: add support for time64 libcs (asterisk[master])

Philip Prindeville asteriskteam at digium.com
Tue Mar 1 20:58:10 CST 2022


Attention is currently required from: Joshua Colp, George Joseph, Kevin Harwell, Sebastian Kemper.
Philip Prindeville has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16621 )

Change subject: time: add support for time64 libcs
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> In 2013 OpenBSD discussed the y2038 issue at a convention (slides: [1]). Under "Simple instructions for conversions", "Systematic conversions" and "Userland audit" they suggest (long long) casts and %lld.

An even cleaner approach would be to use the opaque functions localtime()/strftime() and strptime()/mktime() to convert time_t's to/from strings, respectively.  I've done this in my alternate PR.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16621
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic8d61b26033f5c486b917e738c9608b0923a844e
Gerrit-Change-Number: 16621
Gerrit-PatchSet: 4
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Comment-Date: Wed, 02 Mar 2022 02:58:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Sebastian Kemper <sebastian_ml at gmx.net>
Comment-In-Reply-To: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220301/2d817444/attachment.html>


More information about the asterisk-code-review mailing list