[Asterisk-code-review] apps/confbridge: Added hearjoin option to control who hears sound_join (asterisk[16])

[Joshua Colp]

Attention is currently required from: Michael Cargile.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18072 )

Change subject: apps/confbridge: Added hearjoin option to control who hears sound_join
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File apps/app_confbridge.c:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/6a7c7a50_2b85054e 
PS3, Line 2723: 	/* Play the Join sound to both the conference and the user entering. */
This comment is no longer accurate


File apps/confbridge/conf_config_parser.c:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/f5dc309a_c169ce82 
PS3, Line 100: 				<configOption name="hearjoin">
The standard for ConfBridge is to separate things using _. I also think the name of this option can be confusing for users - I think the option name should make it clear that this is for the users own join sound, and not the join sound for others. hear_own_join_sound?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18072
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I856bd66dc0dfa057323860a6418c1371d249abd2
Gerrit-Change-Number: 18072
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Cargile <mikec at vicidial.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Michael Cargile <mikec at vicidial.com>
Gerrit-Comment-Date: Tue, 01 Mar 2022 13:44:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220301/ee6f37a5/attachment.html>