[Asterisk-code-review] Makefile: Avoid git-make user conflict (asterisk[16])

Michael Bradeen asteriskteam at digium.com
Thu Jun 30 11:41:03 CDT 2022


Attention is currently required from: Joshua Colp, George Joseph.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18605 )

Change subject: Makefile: Avoid git-make user conflict
......................................................................


Patch Set 4:

(2 comments)

File Makefile:

https://gerrit.asterisk.org/c/asterisk/+/18605/comment/09913267_0d258a51 
PS3, Line 704: 	@echo "git config --global --add safe.directory "$(mkfile_dir:/=)
> I think this can be confusing - specifically current user. Can we either change the language to be: […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18605/comment/1c79f2dd_c251f323 
PS3, Line 897: 	@echo "adding the current directory as a global safe.directory"
> The resolution suggestion should be the same as the previous message
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If8f10cac8f509c08981120f17555762342020221
Gerrit-Change-Number: 18605
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 16:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220630/9e07b245/attachment.html>


More information about the asterisk-code-review mailing list