[Asterisk-code-review] res_pjsip: delay contact pruning on Asterisk start (asterisk[16])

[Michael Neuhauser]

Attention is currently required from: N A, Joshua Colp.
Michael Neuhauser has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18681 )

Change subject: res_pjsip: delay contact pruning on Asterisk start
......................................................................


Patch Set 3:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18681/comment/b80eec15_5935b8e9 
PS1, Line 9: Move the call to ast_sip_location_prune_boot_contacts() *after* the call to
> Could you fix the wrapping of your commit message? 72 cols or fewer per line.
Done


Patchset:

PS3: 
Fixed commit message wrapping and added comment regarding initialisation order as requested.


File res/res_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18681/comment/b0d089c3_9c113cab 
PS2, Line 2657: 
> I think this should have a comment explaining it's positioning in ordering.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18681
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1ba4478019e4931a7085f62708d9b66837e901a8
Gerrit-Change-Number: 18681
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Neuhauser <mike at firmix.at>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 12:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220624/ad77875b/attachment-0001.html>