[Asterisk-code-review] res_prometheus: Optional load res_pjsip_outbound_registration.so (asterisk[18])

Joshua Colp asteriskteam at digium.com
Fri Jun 24 03:51:40 CDT 2022


Attention is currently required from: Boris P. Korzun.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18614 )

Change subject: res_prometheus: Optional load res_pjsip_outbound_registration.so
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
I thought this function was in res_pjsip_outbound_registration for some reason, if it's in the core prometheus code then the optional API functionality isn't required, so you can revert back - and add a comment that the function is local.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18614
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia34f1684d984e821fbdd4de8911f930337703666
Gerrit-Change-Number: 18614
Gerrit-PatchSet: 2
Gerrit-Owner: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Comment-Date: Fri, 24 Jun 2022 08:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220624/584a93a6/attachment.html>


More information about the asterisk-code-review mailing list