[Asterisk-code-review] res_prometheus: Optional load res_pjsip_outbound_registration.so (asterisk[18])

[Joshua Colp]

Attention is currently required from: Boris P. Korzun.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18614 )

Change subject: res_prometheus: Optional load res_pjsip_outbound_registration.so
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File res/res_prometheus.c:

https://gerrit.asterisk.org/c/asterisk/+/18614/comment/215496a2_a42466e2 
PS1, Line 981: 		if (pjsip_outbound_registration_metrics_init())
I don't think this is truly sufficient. This relies on the system to do lazy symbol resolution, which may or may not work. For cases where we have an optional API call such as this there is an API[1] that is available. It more widely supports different distros and GCC versions than the check and usage here. In this case I think the stub would just return 0.

[1] https://github.com/asterisk/asterisk/blob/master/include/asterisk/optional_api.h



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18614
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia34f1684d984e821fbdd4de8911f930337703666
Gerrit-Change-Number: 18614
Gerrit-PatchSet: 1
Gerrit-Owner: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-Reviewer: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Attention: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Comment-Date: Wed, 22 Jun 2022 09:37:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220622/5f773fac/attachment.html>