[Asterisk-code-review] Makefile: Avoid git-make user conflict (asterisk[16])

[Joshua Colp]

Attention is currently required from: Michael Bradeen, George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18605 )

Change subject: Makefile: Avoid git-make user conflict
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File Makefile:

https://gerrit.asterisk.org/c/asterisk/+/18605/comment/25141db1_b0438f44 
PS3, Line 704: 	@echo "git config --global --add safe.directory "$(mkfile_dir:/=)
I think this can be confusing - specifically current user. Can we either change the language to be:

"as the user you are executing make install as" or can we include the username in the message?


https://gerrit.asterisk.org/c/asterisk/+/18605/comment/8e906b5f_80788b6f 
PS3, Line 897: 	@echo "adding the current directory as a global safe.directory"
The resolution suggestion should be the same as the previous message



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If8f10cac8f509c08981120f17555762342020221
Gerrit-Change-Number: 18605
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 09:33:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220622/612e5cf1/attachment-0001.html>