[Asterisk-code-review] cdr: Allow bridging and dial state changes to be ignored. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18603 )

Change subject: cdr: Allow bridging and dial state changes to be ignored.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Patchset:

PS3: 
Since these options also fundamentally alter CDR behavior, I think they need test coverage as well.


File main/cdr.c:

https://gerrit.asterisk.org/c/asterisk/+/18603/comment/6f147588_57996f39 
PS3, Line 4614: 	if (!mod_cfg || !ast_test_flag(&mod_cfg->general->settings, CDR_IGNORE_DIAL_CHANGES)) {
The CDR functionality allows reload. Right now reloading with changing these options will result in no change, which can cause confusion for users. It either needs to be supported or explicitly documented that reloading these are not supported.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18603
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I393981af42732ec5ac3ff9266444abb453b7c832
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 09:29:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220622/0710a709/attachment.html>