[Asterisk-code-review] test_aeap_transport: disable part of failing unit test (asterisk[18])

[Kevin Harwell]

Kevin Harwell has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/18610 )

Change subject: test_aeap_transport: disable part of failing unit test
......................................................................

test_aeap_transport: disable part of failing unit test

The 'transport_binary' test sporadically fails, but on a theory that the
problem is caused by a previously executed test, transport_connect_fail,
part of that test has been disabled until a solution is found.

ASTERISK_30099

Change-Id: I48ed74d696aa9b6159f59661f3d535cac4c909e1
---
M tests/test_aeap_transport.c
1 file changed, 13 insertions(+), 6 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved; Approved for Submit
  Benjamin Keith Ford: Looks good to me, but someone else must approve



diff --git a/tests/test_aeap_transport.c b/tests/test_aeap_transport.c
index 675ecf2..e864d44 100644
--- a/tests/test_aeap_transport.c
+++ b/tests/test_aeap_transport.c
@@ -134,15 +134,22 @@
 
 	ast_test_validate(test, !aeap_transport_is_connected(transport));
 
-	aeap_transport_destroy(transport);
+	/*
+	 * The following section of code has been disabled as it may be the cause
+	 * of subsequent test failures.
+	 *
+	 * See ASTERISK-30099 for more information
+	 */
 
-	/* Test invalid protocol */
-	ast_test_validate(test, (transport = aeap_transport_create(TRANSPORT_URL)));
+	/* aeap_transport_destroy(transport); */
 
-	ast_test_validate(test, aeap_transport_connect(transport,
-		TRANSPORT_URL, TRANSPORT_PROTOCOL_INVALID, TRANSPORT_TIMEOUT));
+	/* /\* Test invalid protocol *\/ */
+	/* ast_test_validate(test, (transport = aeap_transport_create(TRANSPORT_URL))); */
 
-	ast_test_validate(test, !aeap_transport_is_connected(transport));
+	/* ast_test_validate(test, aeap_transport_connect(transport, */
+	/* 	TRANSPORT_URL, TRANSPORT_PROTOCOL_INVALID, TRANSPORT_TIMEOUT)); */
+
+	/* ast_test_validate(test, !aeap_transport_is_connected(transport)); */
 
 	return AST_TEST_PASS;
 }

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18610
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I48ed74d696aa9b6159f59661f3d535cac4c909e1
Gerrit-Change-Number: 18610
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220616/6957506b/attachment.html>