[Asterisk-code-review] Changes required for Python 3 compatibility (starpy[1.1])

Michael Bradeen asteriskteam at digium.com
Tue Jun 14 17:01:57 CDT 2022


Attention is currently required from: Michael Bradeen.
Hello Joshua Colp, Kevin Harwell, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/starpy/+/18244

to look at the new patch set (#4).

Change subject: Changes required for Python 3 compatibility
......................................................................

Changes required for Python 3 compatibility

manager: Replace 'async' reference with 'nowait'.  This change breaks backwards
compatibility with previous versions of the testsuite, requiring a matching
change there.

manager and fastagi: twisted in general uses bytes for passing data back and
forth while internally we generally want to deal with strings.  This requires
converting between the two as we interact with the twisted library.

ASTERISK-26826

Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15
---
M starpy/fastagi.py
M starpy/manager.py
2 files changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/starpy refs/changes/44/18244/4
-- 
To view, visit https://gerrit.asterisk.org/c/starpy/+/18244
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: starpy
Gerrit-Branch: 1.1
Gerrit-Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15
Gerrit-Change-Number: 18244
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220614/5cc0e1d9/attachment-0001.html>


More information about the asterisk-code-review mailing list