[Asterisk-code-review] cli: Fix CLI blocking forever on terminating backslash (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18004 )

Change subject: cli: Fix CLI blocking forever on terminating backslash
......................................................................


Patch Set 4:

(3 comments)

File main/asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/18004/comment/d731c873_5457d77b 
PS3, Line 2975: 					/* Abort on malformed tab completes */
> If this solution is kept then I think a more detailed comment as to why would be helpful.
Done


https://gerrit.asterisk.org/c/asterisk/+/18004/comment/93135868_b48e737c 
PS3, Line 2976: 					break;
> Should this return vs break?
It works correctly with break, and that allows the existing return logic to be used since the return type isn't void.


https://gerrit.asterisk.org/c/asterisk/+/18004/comment/a542be16_809fed5b 
PS3, Line 2984: 		matches = ast_el_strtoarr(mbuf);
> If I understand, and if the edge case is triggered then mbuf now has "Usage: .... […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18004
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9810ac59304fec162da701653c9c834f0ec8f670
Gerrit-Change-Number: 18004
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Sat, 11 Jun 2022 20:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220611/69d1a000/attachment.html>