[Asterisk-code-review] res_pjsip_header_funcs: Add functions PJSIP_RESPONSE_HEADER and PJSIP... (asterisk[master])

[José Lopes]

Attention is currently required from: Joshua Colp, N A.
José Lopes has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18367 )

Change subject: res_pjsip_header_funcs: Add functions PJSIP_RESPONSE_HEADER and PJSIP_RESPONSE_HEADERS
......................................................................


Patch Set 5:

(5 comments)

Patchset:

PS5: 
Thanks again for your feedback.
I updated the commit.
Let me know if it is necessary anything more.


File doc/CHANGES-staging/res_pjsip_header_funcs.txt:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/b4866ce0_4a7e33d9 
PS4, Line 3: Add function PJSIP_RESPONSE_HEADERS() to get list of response headers by pattern in the same way as PJSIP_HEADERS() for request headers.
> This should specify that it is for headers from 200 response.
Ack


File res/res_pjsip_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/7af8cd46_ec039132 
PS4, Line 173: 			Gets headers of 2xx response from an outbound PJSIP channel.
> There's conflicting comments in this issue. In some places you say 200, here you say 2xx. […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/7901e8ce_550ae1c8 
PS4, Line 350: 	// Skip responses before 2xx OK
> We use /* and */ for comments
Ack


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/32803a9e_57e7b56f 
PS4, Line 351: 	if (session->inv_session->state < PJSIP_INV_STATE_CONNECTING) {
> I think it would be better to instead look at the response code and limit it to 2xx class instead.
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18367
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I264a610a9333359297a0825feb29a1bb4f4ad144
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 5
Gerrit-Owner: José Lopes <jose.lopes at nfon.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 15:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220608/6829ac07/attachment-0001.html>