[Asterisk-code-review] Makefile: Avoid git-make user conflict (asterisk[16])

[Michael Bradeen]

Attention is currently required from: George Joseph.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18605 )

Change subject: Makefile: Avoid git-make user conflict
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS1: 
> The problem with this approach is that you can't do a "sudo make install" on a clean tree and expect […]
Went a different direction, and added a new failure similar to the previous UNKNOWN.  We can check this in the targets and warn/error.


File build_tools/list_valid_installed_externals:

https://gerrit.asterisk.org/c/asterisk/+/18605/comment/6f0e626e_975f80e5 
PS1, Line 41: version=$(${ASTTOPDIR}/build_tools/make_version ${ASTTOPDIR})
> make_version gets called in download_externals as well. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If8f10cac8f509c08981120f17555762342020221
Gerrit-Change-Number: 18605
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 07 Jun 2022 22:19:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220607/4408d47c/attachment.html>