[Asterisk-code-review] Makefile: Avoid git-make user conflict (asterisk[16])

[George Joseph]

Attention is currently required from: Michael Bradeen.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18605 )

Change subject: Makefile: Avoid git-make user conflict
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1: 
The problem with this approach is that you can't do a "sudo make install" on a clean tree and expect it to build and install. 

Options:
Always run make_version as the directory owner: sudo -u $(MAKEGUID) build_tools/make_version

Add a flag "--set-safe-directory" to ./configure and have the Makefile check it.  If it's set AND the current user isn't the directory owner, issue a "git config --global --add safe.directory <builddir>" before calling make_version.


Also, do we have any idea on how other projects might be handling this?  We can't be the only ones with the issue.


File build_tools/list_valid_installed_externals:

https://gerrit.asterisk.org/c/asterisk/+/18605/comment/6c9d2320_c34ea714 
PS1, Line 41: version=$(${ASTTOPDIR}/build_tools/make_version ${ASTTOPDIR})
make_version gets called in download_externals as well.  Does that need to change as well?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If8f10cac8f509c08981120f17555762342020221
Gerrit-Change-Number: 18605
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Mon, 06 Jun 2022 12:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220606/967f628a/attachment-0001.html>