[Asterisk-code-review] say: Abort play loop if caller hangs up. (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18575 )

Change subject: say: Abort play loop if caller hangs up.
......................................................................


Patch Set 3:

(2 comments)

File main/say.c:

https://gerrit.asterisk.org/c/asterisk/+/18575/comment/7ee653d6_2dc26a24 
PS2, Line 200: 			if (res > 0) {
> Perhaps this should be changed to if (!res)?
Ack


https://gerrit.asterisk.org/c/asterisk/+/18575/comment/54e0e2f2_a5700e2c 
PS2, Line 206: 		if (res < 0) {
             : 			break;
             : 		}
> This now makes it possible to break out of the loop without stopping the stream if an error occurs i […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18575
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I55e85be28ee90b48c0fe4ce20ac136a7dbb49f14
Gerrit-Change-Number: 18575
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 02 Jun 2022 18:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220602/b312e7f6/attachment-0001.html>