[Asterisk-code-review] chan_pjsip: Add option to not play music on hold on unanswered channels (asterisk[master])

[sungtae kim]

Attention is currently required from: Sean Bright, Joshua Colp, N A, Kevin Harwell.
sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18781 )

Change subject: chan_pjsip: Add option to not play music on hold on unanswered channels
......................................................................


Patch Set 10:

(4 comments)

Patchset:

PS10: 
recheck


File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/efae4428_d41dd739 
PS9, Line 1772: 					ast_sorcery_object_get_id(channel->session),
> Sessions aren't a sorcery object, you can't get the id of them. Channel name would be better.
Done


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/143d9b4e_cb813798 
PS9, Line 934: 	/*! Only allow answered channels to have music on hold. Enabling this will prevent MOH on unanswered channels. */
> That is, if you plan on submitting this to other branches.
Done


https://gerrit.asterisk.org/c/asterisk/+/18781/comment/ccb0726a_6216c39c 
PS9, Line 934: 	/*! Only allow answered channels to have music on hold. Enabling this will prevent MOH on unanswered channels. */
> That is, if you plan on submitting this to other branches.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3c9b9101e4dc85338154b8004cecdd3edc227474
Gerrit-Change-Number: 18781
Gerrit-PatchSet: 10
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Sat, 30 Jul 2022 04:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220729/82c1446a/attachment-0001.html>