[Asterisk-code-review] res_hiredis: REDIS DeviceState and Dialplan functions (asterisk[master])

[Alec Davis]

Attention is currently required from: Sean Bright, N A, Joshua Colp.
Alec Davis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_hiredis: REDIS DeviceState and Dialplan functions
......................................................................


Patch Set 17:

(2 comments)

Patchset:

PS17: 
This patchset 17 deals with working around 
"function ‘function_db_direct’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]"

Which caused me to have to change my original "hiredis_command(buf, len - 1, parse);
to hiredis_command(buf, len - 1, "%s", parse);
That removed the annoying 'might be a candidate for ‘gnu_printf’ format attribute' */

Which lead to hiredis library now complaining with 
ERR unknown command `incr pabx:20220730:external:inbound:9100:calls`, with args beginning with:

Now 2 wrapper routines hiredis_commandv and hiredis_command_direct essentially identical except for the call to hiredis_command_common where the 3rd parameter influences whether redisvCommand or  redisCommand is called.


File res/res_hiredis.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/7ad958da_598dbe2f 
PS17, Line 365:  
redness



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 17
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 30 Jul 2022 04:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220729/fe50478e/attachment.html>