[Asterisk-code-review] res_crypto: Use EVP API's instead of legacy API's (asterisk[master])

Philip Prindeville asteriskteam at digium.com
Tue Jul 26 15:41:26 CDT 2022


Attention is currently required from: Sean Bright, Joshua Colp, Stanislav Abramenkov, George Joseph.
Philip Prindeville has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18534 )

Change subject: res_crypto: Use EVP API's instead of legacy API's
......................................................................


Patch Set 24:

(3 comments)

File res/res_crypto.c:

https://gerrit.asterisk.org/c/asterisk/+/18534/comment/29a463f0_551f86f5 
PS23, Line 71: #define	RSA_PKCS_OAEP_PADDING_SIZE		41
> Document where this comes from.
Done


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/bcba39ad_6c4ffb81 
PS23, Line 362: 	ctx = EVP_MD_CTX_create();
> Handle failure of this.
Done


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/cda3e09b_f9e5e17c 
PS23, Line 594: 	ctx = EVP_MD_CTX_create();
> Handle failure of this
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18534
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5c738756de75fd27ebad54be144c0ac6193f21b2
Gerrit-Change-Number: 18534
Gerrit-PatchSet: 24
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 20:41:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/459b2454/attachment.html>


More information about the asterisk-code-review mailing list