[Asterisk-code-review] res_pjsip: Add 100rel option "peer_supported" (asterisk[16])

[Maximilian Fridrich]

Attention is currently required from: N A, Joshua Colp.
Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18838 )

Change subject: res_pjsip: Add 100rel option "peer_supported"
......................................................................


Patch Set 2:

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/71e9cb5b_2c0b5332 
PS1, Line 7: res_pjsip: Add 100rel option "use_if_supported"
> I'm not a fan of use_if_supported as an option. I think "peer_supported" makes more sense.
Done


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/bd345c3b_06ba79f5 
PS1, Line 896: 	enum ast_sip_100rel_mode rel100;
> This should go at the end of the structure.
Done


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/830168cb_087c634f 
PS1, Line 39: 						</enumlist>
> Some explanation of the difference between required, yes, and use_if_supported might be useful, espe […]
Done


File res/res_pjsip/pjsip_configuration.c:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/57f6abf1_62452336 
PS1, Line 192: 	} else if (ast_false(var->value)){
> Missing space between close paren and brace
Done


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/fbbd8ad6_0200569c 
PS1, Line 3805: 	for (i = 0; i < rdata->msg_info.supported->count; ++i) {
> If endpoint->rel100 isn't USE_IF_SUPPORTED this for loop doesn't need to occur, and in the for loop  […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18838
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 15:51:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/955bfd8d/attachment-0001.html>