[Asterisk-code-review] test: Add ability to capture child process output (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Jul 26 09:54:03 CDT 2022


Attention is currently required from: Philip Prindeville.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18525 )

Change subject: test: Add ability to capture child process output
......................................................................


Patch Set 11: Code-Review-1

(2 comments)

File main/Makefile:

https://gerrit.asterisk.org/c/asterisk/+/18525/comment/25a3036c_39983899 
PS11, Line 170: test.o: _ASTCFLAGS+=-DASTMM_LIBC=ASTMM_IGNORE
Document why this is here.


File main/test.c:

https://gerrit.asterisk.org/c/asterisk/+/18525/comment/9f74bc11_98376dfa 
PS11, Line 113: #define min(a, b) \
MIN and MAX already exist in utils.h



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18525
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icbf84ce05addb197a458361c35d784e460d8d6c2
Gerrit-Change-Number: 18525
Gerrit-PatchSet: 11
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 14:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/fce1f600/attachment-0001.html>


More information about the asterisk-code-review mailing list