[Asterisk-code-review] res_crypto: Use EVP API's instead of legacy API's (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Jul 26 09:57:15 CDT 2022


Attention is currently required from: Sean Bright, Stanislav Abramenkov, George Joseph, Philip Prindeville.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18534 )

Change subject: res_crypto: Use EVP API's instead of legacy API's
......................................................................


Patch Set 23: Code-Review-1

(3 comments)

File res/res_crypto.c:

https://gerrit.asterisk.org/c/asterisk/+/18534/comment/4fbb33a2_26911a75 
PS23, Line 71: #define	RSA_PKCS_OAEP_PADDING_SIZE		41
Document where this comes from.


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/ab1ba6ac_cfe25015 
PS23, Line 362: 	ctx = EVP_MD_CTX_create();
Handle failure of this.


https://gerrit.asterisk.org/c/asterisk/+/18534/comment/6f682b75_59262f65 
PS23, Line 594: 	ctx = EVP_MD_CTX_create();
Handle failure of this



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18534
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5c738756de75fd27ebad54be144c0ac6193f21b2
Gerrit-Change-Number: 18534
Gerrit-PatchSet: 23
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 14:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/ff854c24/attachment.html>


More information about the asterisk-code-review mailing list