[Asterisk-code-review] test: Add test coverage for capture child process output (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Philip Prindeville.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18526 )

Change subject: test: Add test coverage for capture child process output
......................................................................


Patch Set 14: Code-Review-1

(2 comments)

File tests/Makefile:

https://gerrit.asterisk.org/c/asterisk/+/18526/comment/1257f4a3_a1d95ffd 
PS14, Line 24: test_strings.o: _ASTCFLAGS+=$(AST_NO_FORMAT_TRUNCATION) $(AST_NO_STRINGOP_TRUNCATION)
Comment why this is needed


File tests/test_capture.c:

https://gerrit.asterisk.org/c/asterisk/+/18526/comment/8e9a1dc3_7ffbf143 
PS14, Line 46: 	const char *path = "true";
To be tolerant the test should confirm that any pre-requisities, such as true being present, are there. Logically it should be but just in case. The same goes for the other commands.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18526
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0273e85eeeb6b8e46703f24cd74d84f3daf0a69a
Gerrit-Change-Number: 18526
Gerrit-PatchSet: 14
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 14:59:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220726/f29429a8/attachment.html>