[Asterisk-code-review] DeviceState and Dialplan support for Redis DB (asterisk[master])

[Alec Davis]

Attention is currently required from: Joshua Colp, N A.
Alec Davis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: DeviceState and Dialplan support for Redis DB
......................................................................


Patch Set 10:

(1 comment)

Patchset:

PS10: 
Patchset 10, white space and typo in documentation.

Rational for separate res_redisd;

1. One module to deal with configs, threadsafe connect/disconnect, socket file descriptor leaks. 
2. Code deduplication. func_db_redis and res_redis_device_state would have all of res_redisd in each module.

I originally had one monolithic res module with all funcs and resources calling 1 common function which is now in res_redisd, to handle connection setup(with optional AUTH and DB selection), retry/reconnect, the Redis operation, then teardown, with no file descriptor leaks, and was threadsafe.

But not to the extent to have each function use native hiredis function calls to setup a socket to redis, reconnect/retry if that failed, do the redis operation, then teardown the socket.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 10
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 00:52:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220725/8b5c0d53/attachment.html>