[Asterisk-code-review] general: Improve logging levels of some log messages. (asterisk[master])

Sean Bright asteriskteam at digium.com
Sun Jul 24 11:47:27 CDT 2022


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18831 )

Change subject: general: Improve logging levels of some log messages.
......................................................................


Patch Set 2:

(1 comment)

File channels/chan_dahdi.c:

https://gerrit.asterisk.org/c/asterisk/+/18831/comment/60fad986_af106f13 
PS2, Line 19413: 		} else if (!(options & PROC_DAHDI_OPT_NOWARN) )
> It's !, so if not NO_WARN, then do it. […]
I am saying it's odd to have a variable with the word "WARN" in its name now controlling something that is _not_ a LOG_WARNING. It's fine how you have it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18831
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifc8f7df427aa018627db462125ae744986d3261b
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sun, 24 Jul 2022 16:47:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220724/c1503d6b/attachment-0001.html>


More information about the asterisk-code-review mailing list