[Asterisk-code-review] general: Improve logging levels of some log messages. (asterisk[master])

[Sean Bright]

Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18831 )

Change subject: general: Improve logging levels of some log messages.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

File apps/app_waituntil.c:

https://gerrit.asterisk.org/c/asterisk/+/18831/comment/3a433f34_cb40f205 
PS2, Line 97: 		ast_log(LOG_WARNING, "WaitUntil called in the past (now %ld, arg %ld)\n", (long)now.tv_sec, (long)future.tv_sec);
This should not be a warning. When dealing with absolute times, passing something in the past is reasonable.


File channels/chan_dahdi.c:

https://gerrit.asterisk.org/c/asterisk/+/18831/comment/411271dd_770a5b78 
PS2, Line 19413: 		} else if (!(options & PROC_DAHDI_OPT_NOWARN) )
It's confusing that the option controlling this log message is ..._NOWARN but then we emit a NOTICE?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18831
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifc8f7df427aa018627db462125ae744986d3261b
Gerrit-Change-Number: 18831
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sun, 24 Jul 2022 16:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220724/c3fed4b4/attachment.html>