[Asterisk-code-review] pbx_functions.c: Fix buggy ast_str_strlen. (asterisk[master])

N A asteriskteam at digium.com
Sun Jul 24 10:21:21 CDT 2022


Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18833 )

Change subject: pbx_functions.c: Fix buggy ast_str_strlen.
......................................................................


Patch Set 3:

(1 comment)

File main/pbx_functions.c:

https://gerrit.asterisk.org/c/asterisk/+/18833/comment/0ccdbac1_1833a2ac 
PS2, Line 681: 			(*str)->__AST_STR_USED = strlen(ast_str_buffer(*str)); /* Manually set the string length */
> https://github.com/asterisk/asterisk/blob/master/include/asterisk/strings. […]
Totally missed that, thanks for the catch.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18833
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4e2dba41410f9d4dff61c995d2ca27718248e07f
Gerrit-Change-Number: 18833
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Sun, 24 Jul 2022 15:21:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220724/ad55c74b/attachment-0001.html>


More information about the asterisk-code-review mailing list