[Asterisk-code-review] res_redisd: add REDIS support modules to send asterisk DeviceState up... (asterisk[master])

Alec Davis asteriskteam at digium.com
Sat Jul 23 20:38:20 CDT 2022


Attention is currently required from: Joshua Colp, N A.
Alec Davis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_redisd: add REDIS support modules to send asterisk DeviceState updates to a REDIS server
......................................................................


Patch Set 5:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/491d6b80_c63a4c51 
PS4, Line 7: revert deleted files that create 10000 lines of change
> The commit message should go back to the way it was.
Done


Patchset:

PS4: 
> Thanks Josh […]
Done


File res/res_redisd.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/da3f42b5_e00c642b 
PS4, Line 361: 	if (!(cfg = ao2_alloc(sizeof(*cfg), conf_destructor))) {
> I thought I was doing it the same way as these listed below, I started with res/res_statsd. […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 5
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sun, 24 Jul 2022 01:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Alec Davis <alec at bdt.co.nz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220723/271781af/attachment.html>


More information about the asterisk-code-review mailing list