[Asterisk-code-review] res_redisd: add REDIS support modules to send asterisk DeviceState up... (asterisk[master])
N A
asteriskteam at digium.com
Thu Jul 21 05:26:47 CDT 2022
Attention is currently required from: Alec Davis.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18828 )
Change subject: res_redisd: add REDIS support modules to send asterisk DeviceState updates to a REDIS server
......................................................................
Patch Set 1: Code-Review-1
(13 comments)
File configs/samples/redisd.conf.sample:
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/e42fe16b_5a12519e
PS1, Line 1: [general]
The sample config is a little sparse, though maybe there isn't really much to say.
A small intro as to how this module can be configured might be nice.
File include/asterisk/redisd.h:
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/0d4dd357_199ddee3
PS1, Line 6: * David M. Lee, II <dlee at digium.com>
Copyright looks wrong? Is this file really his or yours?
File res/res_redis_device_state.c:
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/2daffb7d_2582ae4b
PS1, Line 4: * Copyright (C) 2005-2006, Digium, Inc.
Remove this - copyright is yours not Digium's
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/de285944_02113dc6
PS1, Line 80: //throw away result
Use /* comments */ only.
// comments don't exist in the C89 standard.
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/9e4dca6a_98208453
PS1, Line 81: char return_buffer[4096];
Did you compile in developer mode? Mixed variables and declarations are *not* permitted.
File res/res_redisd.c:
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/92de0a42_0e3fd2e2
PS1, Line 4: * Copyright (C) 2005-2006, Digium, Inc.
Remove this. The copyright is yours, not Digium's.
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/6038ecfa_06d77b9e
PS1, Line 27: *
formatting seems messed up here?
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/d14cd04b_8d1acd22
PS1, Line 47:
It seems like you're using spaces everywhere, not tabs.
Asterisk uses tabs, not spaces.
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/61e7e14b_b3efdc71
PS1, Line 58: <synopsis>Global configuration settings</synopsis>
For modules that have default options, explicitly specify them here using the appropriate XML attributes.
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/454a5ee1_d3644f4f
PS1, Line 139: if (redisd_context == NULL) {
You could just do !redisd_context
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/25c8ad3a_fda6b9b8
PS1, Line 168: ast_log(LOG_DEBUG, "Authenticated.\n");
Use ast_debug(level, fmt, ...) not ast_log(LOG_DEBUG, fmt, ...)
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/ddee27c8_6b28e8ed
PS1, Line 248:
redness (trailing whitespace)
https://gerrit.asterisk.org/c/asterisk/+/18828/comment/510fd278_e6776f9c
PS1, Line 305:
redness
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18828
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I17dc11b1d0b4d046a3f092ddf7778108dbcd1cce
Gerrit-Change-Number: 18828
Gerrit-PatchSet: 1
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alec Davis <alec at bdt.co.nz>
Gerrit-Comment-Date: Thu, 21 Jul 2022 10:26:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220721/f0d71ff9/attachment-0001.html>
More information about the asterisk-code-review
mailing list