[Asterisk-code-review] cel_odbc & res_config_odbc: Add support for SQL_DATETIME field type (asterisk[16])

Joshua Colp asteriskteam at digium.com
Mon Jul 11 04:13:01 CDT 2022


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/18606 )

Change subject: cel_odbc & res_config_odbc: Add support for SQL_DATETIME field type
......................................................................

cel_odbc & res_config_odbc: Add support for SQL_DATETIME field type

See also: ASTERISK_30023

ASTERISK-30096 #close
patches:
  inline on issue - submitted by Morvai Szabolcs

Change-Id: I79c0b74862100acd9c8319dca5cc456a654d02eb
---
M cel/cel_odbc.c
M res/res_config_odbc.c
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, approved



diff --git a/cel/cel_odbc.c b/cel/cel_odbc.c
index 12f4a06..f73eece 100644
--- a/cel/cel_odbc.c
+++ b/cel/cel_odbc.c
@@ -606,6 +606,7 @@
 					break;
 				case SQL_TYPE_TIMESTAMP:
 				case SQL_TIMESTAMP:
+				case SQL_DATETIME:
 					if (ast_strlen_zero(colptr)) {
 						continue;
 					} else {
diff --git a/res/res_config_odbc.c b/res/res_config_odbc.c
index 178a483..b6a878a 100644
--- a/res/res_config_odbc.c
+++ b/res/res_config_odbc.c
@@ -1133,6 +1133,7 @@
 					break;
 				case SQL_TYPE_TIMESTAMP:
 				case SQL_TIMESTAMP:
+				case SQL_DATETIME:
 					if (type != RQ_DATE && type != RQ_DATETIME) {
 						warn_type(col, type);
 					}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18606
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I79c0b74862100acd9c8319dca5cc456a654d02eb
Gerrit-Change-Number: 18606
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220711/dcde584e/attachment.html>


More information about the asterisk-code-review mailing list