[Asterisk-code-review] Geolocation: Core Capability Preview (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Thu Jul 7 10:22:18 CDT 2022


Attention is currently required from: Stanislav Abramenkov, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18696 )

Change subject: Geolocation:  Core Capability Preview
......................................................................


Patch Set 2:

(2 comments)

File res/res_geolocation/eprofile_to_pidf.xslt:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/b5dbf43a_fd83b6ea 
PS2, Line 191: 	
Looks like one whitespace got missed


File res/res_geolocation/geoloc_eprofile.c:

https://gerrit.asterisk.org/c/asterisk/+/18696/comment/eedb67d4_e1ac2174 
PS1, Line 845: //		geoloc_eprofile_unload();
> > Seems like this line should not be commented out? […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18696
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibfde963121b1ecf57fd98ee7060c4f0808416303
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 15:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220707/8162d6a3/attachment.html>


More information about the asterisk-code-review mailing list