[Asterisk-code-review] Geolocation: Base Asterisk Prereqs (asterisk[16])

[George Joseph]

Attention is currently required from: Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18691 )

Change subject: Geolocation: Base Asterisk Prereqs
......................................................................


Patch Set 2:

(2 comments)

File include/asterisk/pbx.h:

https://gerrit.asterisk.org/c/asterisk/+/18691/comment/70e4cf5f_d01423fb 
PS1, Line 1476: void ast_str_substitute_variables_full2(struct ast_str **buf, ssize_t maxlen,
              : 	struct ast_channel *c, struct varshead *headp, const char *templ,
              : 	size_t *used, int use_both);
> Probably unit test worthy.
I'm going to defer this for now.  ast_str_substitute_variables() and  st_str_substitute_variables_full() are just wrappers for  ast_str_substitute_variables_full2() now so the existing test tests all existing functionality.  Only the ability to search a channel, then headp isn't explicitly tested but it's used by geolocation so it's tested as part of that.  I'll add an explicit test to test_substitution.c in the near future.


File include/asterisk/strings.h:

https://gerrit.asterisk.org/c/asterisk/+/18691/comment/850064ed_05616b01 
PS1, Line 327: char *ast_strsep_quoted(char **s, const char sep, const char quote, uint32_t flags);
> A unit test would be good for this too.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18691
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5dcefed2f5f93a109e8b489e18d80d42e45244ec
Gerrit-Change-Number: 18691
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 13:15:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220706/23f4fc51/attachment-0001.html>