[Asterisk-code-review] chan_dahdi: allow audio to pass during call setup phase (asterisk[18])

[Sarah Autumn]

Attention is currently required from: Kevin Harwell.
Sarah Autumn has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17948 )

Change subject: chan_dahdi: allow audio to pass during call setup phase
......................................................................


Patch Set 3:

(3 comments)

Patchset:

PS3: 
Whoops. See notes below.


File channels/chan_dahdi.h:

https://gerrit.asterisk.org/c/asterisk/+/17948/comment/24ba41e9_c555cce1 
PS1, Line 448: unsigned int hearpulsing:0;
> Just a quick glance at this due to the compile errors, but the bitfield can't be a size of 0. […]
Oh, derp. Dumb mistake, sorry. It was 1, but then for some reason I forgot that that is a bit-field size, and not the default value of the config option, so I changed it before committing.

Fix incoming.


File channels/sig_analog.h:

https://gerrit.asterisk.org/c/asterisk/+/17948/comment/fde39e98_75d8a704 
PS1, Line 310: 	unsigned int hearpulsing:0;
> The bitfield can't be a size of 0 (That's what the compiler is complaining about). […]
Yep, sorry. Dumb mistake. This was actually correctly set at 1 in my own copy, but in a quick attempt to correct other mistakes, I changed this. Fix incoming.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibcef6e21020ab6e64f16f4761ec1e0e7fce9c260
Gerrit-Change-Number: 17948
Gerrit-PatchSet: 3
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 00:33:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220131/8f0d54e3/attachment.html>