[Asterisk-code-review] chan_dahdi: allow audio to pass during call setup phase (asterisk[18])

N A asteriskteam at digium.com
Mon Jan 31 18:30:45 CST 2022


Attention is currently required from: Sarah Autumn.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17948 )

Change subject: chan_dahdi: allow audio to pass during call setup phase
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17948/comment/7c08aa5e_33450ffb 
PS1, Line 15: Users can configure this setting in chan_dahdi.conf by using "hearpulsing=yes"
Very minor, but some odd text wrapping around here, can you wrap a bit earlier so it flows more nicely?


Patchset:

PS2: 
Since this adds a new feature, there should be a CHANGES entry for it: https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibcef6e21020ab6e64f16f4761ec1e0e7fce9c260
Gerrit-Change-Number: 17948
Gerrit-PatchSet: 2
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Tue, 01 Feb 2022 00:30:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220131/5f625018/attachment.html>


More information about the asterisk-code-review mailing list