[Asterisk-code-review] res_prometheus.c: missing module dependency (asterisk[18])

[Kevin Harwell]

Attention is currently required from: N A, Mark Petersen.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17913 )

Change subject: res_prometheus.c: missing module dependency
......................................................................


Patch Set 3:

(1 comment)

File res/res_prometheus.c:

https://gerrit.asterisk.org/c/asterisk/+/17913/comment/18e0bb7d_0f359c5a 
PS3, Line 1005: 	.requires = "res_pjsip,res_pjsip_outbound_registration",
A general question as I don't use this module, but should res_prometheus be fully dependent on res_pjsip_outbound_registration module? Maybe someone wants to monitor items but not pjsip specific ones?

I wonder if this should be "optional_modules" or "enhances"?

That might be a bigger change (the module load routine would also have to be aware that module did not load), though, based on the most used use case and unwarranted at this time?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17913
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia0f49d048427a40e1b763296b834a52a03610096
Gerrit-Change-Number: 17913
Gerrit-PatchSet: 3
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Tue, 01 Feb 2022 00:22:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220131/46d2cfb7/attachment.html>