[Asterisk-code-review] chan_dahdi: allow audio to pass during call setup phase (asterisk[18])

[Kevin Harwell]

Attention is currently required from: Sarah Autumn.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17948 )

Change subject: chan_dahdi: allow audio to pass during call setup phase
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Patchset:

PS1: 
When creating a patch for Asterisk I would suggest compiling with --enable-dev-mode configured. It should catch compiler issues like this locally.


File channels/chan_dahdi.h:

https://gerrit.asterisk.org/c/asterisk/+/17948/comment/d4fa4e3c_e3e5c1b5 
PS1, Line 448: unsigned int hearpulsing:0;
Just a quick glance at this due to the compile errors, but the bitfield can't be a size of 0. If you only need one 1 bit then make it a 1.


File channels/sig_analog.h:

https://gerrit.asterisk.org/c/asterisk/+/17948/comment/8f083949_d87c71a8 
PS1, Line 310: 	unsigned int hearpulsing:0;
The bitfield can't be a size of 0 (That's what the compiler is complaining about). If you only need one 1 bit then make it a 1.

Also, move this field to align with other bitfields above.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibcef6e21020ab6e64f16f4761ec1e0e7fce9c260
Gerrit-Change-Number: 17948
Gerrit-PatchSet: 1
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Tue, 01 Feb 2022 00:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220131/d717cbb6/attachment.html>