[Asterisk-code-review] res/res_rtp_asterisk: fix skip in rtp sequence numbers after dtmf (asterisk[master])

Friendly Automation asteriskteam at digium.com
Mon Jan 31 07:52:38 CST 2022


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/17921 )

Change subject: res/res_rtp_asterisk: fix skip in rtp sequence numbers after dtmf
......................................................................

res/res_rtp_asterisk: fix skip in rtp sequence numbers after dtmf

When generating dtmfs, asterisk can incorrectly think packet loss
occured during the dtmf generation, resulting in a jump in sequence
numbers when forwarding voice frames resumes.  This patch forces
asterisk to re-learn the expected sequence number after each DTMF
to avoid this

ASTERISK-29869 #close

Change-Id: Icc7de3d947b207b82c99d3c327af8095884df853
---
M res/res_rtp_asterisk.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index 7024081..0f85a14 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -4359,6 +4359,9 @@
 	rtp->sending_digit = 0;
 	rtp->send_digit = 0;
 
+	/* Re-Learn expected seqno */
+	rtp->expectedseqno = -1;
+
 	return res;
 }
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17921
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icc7de3d947b207b82c99d3c327af8095884df853
Gerrit-Change-Number: 17921
Gerrit-PatchSet: 2
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220131/7672df7c/attachment.html>


More information about the asterisk-code-review mailing list